LCORE-1347 - Restructure source code#2167
Open
samdoran wants to merge 7 commits into
Open
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 441 files, which is 341 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (445)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
samdoran
force-pushed
the
restructure
branch
5 times, most recently
from
July 20, 2026 15:28
d7cfc4c to
9ebe0f4
Compare
Contributor
Author
|
The last E2E test failure was due to the disk being filled on the test runner. |
samdoran
marked this pull request as ready for review
July 20, 2026 15:28
samdoran
force-pushed
the
restructure
branch
4 times, most recently
from
July 22, 2026 15:58
6906f17 to
ec97bd3
Compare
This structure matches what is recommended in the documentation. https://backend.pdm-project.org/build_config/#the-src-layout This will also solve the problem of each folder inside src/ currently being installed as its own package and top level modules missing from the wheel.
Modules inside packages should not be invoked directly.
This is redundant since both ruff and black handle line length.
Using the module this way seems like a major anti-pattern that needs refactoring.
19 tasks
Contributor
Author
|
The |
Contributor
Author
|
The E2E failures are due to an outage affecting quay.io. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to apologize up front for how huge this change is. I tried multiple times to do this less invasively and there was just no way to do it.
The best way to review this it to look through the commits. They are atomic and clearly state the intention of each change set. I tried my best to make this easy on the reviewer, but this one is a bear.
Summary of changes
srcdirectory that are currently omitted from the wheel.__main__.pyso the package can be invoked withpython -m.This should be backported to all release branches since all the currently released versions are missing critical modules.
The wheel now packages the application correctly.
List of files in wheel
Type of change
Tools used to create PR
crushusing Claude Opus 4.6Related Tickets & Documents
Checklist before requesting a review
Testing
make verifyandmake test-unit.lightspeed-stack -c [path to config]